Re: [PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors

[Joe Perches]

On Mon, 2014-09-08 at 17:32 -0500, Greg Donald wrote:
> Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/obdo.c b/drivers/staging/lustre/lustre/obdclass/obdo.c
[]
> @@ -161,35 +161,35 @@ int obdo_cmp_md(struct obdo *dst, struct obdo *src, u32 compare)
>  {
>  	int res = 0;
>  
> -	if ( compare & OBD_MD_FLATIME )
> +	if (compare & OBD_MD_FLATIME)
>  		res = (res || (dst->o_atime != src->o_atime));

These would be nicer as

		res |= dst->o_atime != src->o_atime;

> -	if ( compare & OBD_MD_FLMTIME )
> +	if (compare & OBD_MD_FLMTIME)
>  		res = (res || (dst->o_mtime != src->o_mtime));

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/