Re: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible

[Pavel Machek]

On Fri 2014-09-05 13:13:16, Russell King - ARM Linux wrote:
> On Fri, Sep 05, 2014 at 01:38:40PM +0200, Pali Rohár wrote:
> > On Wednesday 18 June 2014 18:54:24 Pali Rohár wrote:
> > > -	if (!mdesc)
> > > +	if (mdesc)
> > > +		machine_name = of_flat_dt_get_machine_name();
> > > +	else
> > >  		mdesc = setup_machine_tags(__atags_pointer,
> > > __machine_arch_type); machine_desc = mdesc;
> > > -	machine_name = mdesc->name;
> > > +	if (!machine_name)
> > > +		machine_name = mdesc->name;
> > > 
> > >  	if (mdesc->reboot_mode != REBOOT_HARD)
> > >  		reboot_mode = mdesc->reboot_mode;
> > 
> > So, do you really want to break userspace which reading file 
> > /proc/cpuinfo (after migration from boardcode --> DT)?
> > 
> > I still do not see reason for that. And only this one file is 
> > problematic...
> 
> Sorry, I just don't give a damn about your whinging about this.  I've
> made the situation perfectly clear.  Your patch will not be accepted.

Linus made it pretty clear that regressions are not accepted. 

You are an arm maintainer and there is regression in n900 that broke userspace.

How do you solve it?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/