Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers

From: Jiri Kosina
Date: Wed Sep 10 2014 - 10:26:54 EST


On Wed, 10 Sep 2014, Theodore Ts'o wrote:

> I'd much rather depending on better testing and static checkers to fix
> them, since kfree *is* a hot path.

BTW if we stretch this argument a little bit more, we should also kill the
ZERO_OR_NULL_PTR() check from kfree() and make it callers responsibility
to perform the checking only if applicable ... we are currently doing a
lot of pointless checking in cases where caller would be able to guarantee
that the pointer is going to be non-NULL.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/