Re: [PATCH v1 02/13] PCI: Move pci_configure_slot() to drivers/pci/probe.c

[Bjorn Helgaas]

On Fri, Sep 12, 2014 at 3:35 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Fri, Sep 12, 2014 at 3:31 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On Fri, Sep 12, 2014 at 11:03 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>>> Move pci_configure_slot() and related functions from
>>> drivers/pci/hotplug/pcihp_slot to drivers/pci/probe.c.
>>>
>>> This is to prepare for doing device configuration during the normal
>>> enumeration process instead of just after hot-add.
>>>
>>> ...
>
>> Would be better if those acpi related code could be moved to
>> drivers/pci/pci-acpi.c. and should put pci_configure_device() from
>> next patch to pci-acpi.c.
>
> Good point.  I just moved a bunch of the stuff from
> drivers/pci/hotplug/acpi_pcihp.c to pci-acpi.h, because acpi_pcihp.c
> is not compiled unless CONFIG_PCI_HOTPLUG is set.  And this stuff
> probably should go there, too.

On second thought, none of the stuff from pcihp_slot.c
(pci_configure_slot(), program_hpp_type0(), program_hpp_type1(),
program_hpp2()) actually mentions ACPI or uses any ACPI interfaces,
and it is all compiled into pcihp_slot.o today even without
CONFIG_ACPI.  So my patch really doesn't change any of that, except to
make it available when CONFIG_PCI_HOTPLUG is not set.  I'll have to
think about this some more.  It certainly is all implicitly driven by
the ACPI spec and the "hpp", "type0", "type1", etc. names are from
ACPI, so maybe it could be abstracted better somehow.

>> Other that,  for the whole patchset,
>>
>> Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/