Re: [PATCH v2 6/6] mm/balloon_compaction: general cleanup

[Andrew Morton]

On Fri, 12 Sep 2014 17:04:04 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Sat, 30 Aug 2014 20:41:27 +0400 Konstantin Khlebnikov <koct9i@xxxxxxxxx> wrote:
> 
> > * move special branch for balloon migraion into migrate_pages
> > * remove special mapping for balloon and its flag AS_BALLOON_MAP
> > * embed struct balloon_dev_info into struct virtio_balloon
> > * cleanup balloon_page_dequeue, kill balloon_page_free
> 
> Not sure what's going on here - your include/linux/balloon_compaction.h
> seems significantly different from mine.

OK, I worked it out.

> I think I'll just drop this patch - it's quite inconvenient to have a
> large "general cleanup" coming after a stack of significant functional
> changes.  It makes review, debug, fix, merge and reversion harder. 
> Let's worry about it later.

But I'm still thinking we should defer this one?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/