RE: [PATCH v8 04/10] x86, mpx: hook #BR exception handler to allocate bound tables

From: Ren, Qiaowei
Date: Sat Sep 13 2014 - 03:24:30 EST




On 2014-09-13, Hansen, Dave wrote:
> On 09/11/2014 01:46 AM, Qiaowei Ren wrote:
>> +static int allocate_bt(long __user *bd_entry) {
>> + unsigned long bt_addr, old_val = 0;
>> + int ret = 0;
>> +
>> + bt_addr = mpx_mmap(MPX_BT_SIZE_BYTES);
>> + if (IS_ERR((void *)bt_addr))
>> + return bt_addr;
>> + bt_addr = (bt_addr & MPX_BT_ADDR_MASK) |
> MPX_BD_ENTRY_VALID_FLAG;
>
> Qiaowei, why do we need the "& MPX_BT_ADDR_MASK" here?

It should be not necessary, and can be removed.

Thanks,
Qiaowei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/