Re: [PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

From: Joe Perches
Date: Sun Sep 14 2014 - 18:35:21 EST


On Sun, 2014-09-14 at 15:14 -0700, Jaegeuk Kim wrote:
> This patch cleans up a simple macro.

There seems to be many different types used here.

MAX_BIO_BLOCKS returns unsigned int
bio_blocks is int,
blocks_per_seg is unsigned int,
ra_meta_pages(,,int,)
nr_pages_to_skip uses int
nr_pages_to_write returns a long

Perhaps it'd be nicer to standardize the type
so there'd be fewer promotions/implicit casts.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/