Re: [PATCH RESEND v9 5/5] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

[Javier Martinez Canillas]

Hello Andrew,

On 09/13/2014 12:13 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 10:17:43 +0200 Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> wrote:
> 
>> The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
>> This patch adds support for the RTC and is based on a driver
>> added by Simon Glass to the Chrome OS kernel 3.8 tree.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> 
> Would it be appropriate to gather Simon's signoff?
> 

I don't know. The original driver written by Simon supported 2 devices:
max77686 and max77802. I split the max77802 bits and addressed all the issues
pointed out on early revisions so even when Simon is mentioned as the
MODULE_AUTHOR(), I didn't know if he would like his s-o-b to remain in the
patch since it was quite different than the original one from which was based.

>> +static inline int max77802_rtc_calculate_wday(u8 shifted)
>> +{
>> +	int counter = -1;
>> +
>> +	while (shifted) {
>> +		shifted >>= 1;
>> +		counter++;
>> +	}
> 
> Can't use log2() or similar?
> 

Yes, ffs() - 1 can be used instead of this function indeed.

I see that you already included this patch to your -mm tree [0]. Does it mean
that I've to send a follow-up patch on top of this to remove this function or
should I send a new version of this patch?

Best regards,
Javier

[0]:
http://ozlabs.org/~akpm/mmots/broken-out/rtc-add-driver-for-maxim-77802-pmic-real-time-clock.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/