Re: [PATCH v4 9/9] mfd: syscon: add Atmel GPBR DT bindings documention

From: Lee Jones
Date: Wed Sep 17 2014 - 17:32:25 EST


On Wed, 17 Sep 2014, Boris BREZILLON wrote:
> On Wed, 17 Sep 2014 09:34:05 -0700
> Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> > On Thu, 11 Sep 2014, Boris BREZILLON wrote:
> >
> > > The GPBR block provides a set of battery-backed registers that can be used
> > > to save data which need to be kept when the system is powered down and
> > > VDD-core is maintained by an external battery.
> > >
> > > A typical usage is the RTT block (when used as an RTC) which needs one of
> > > those registers to save the current time.
> > >
> > > Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > > ---
> > > Documentation/devicetree/bindings/mfd/atmel,gpbr.txt | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt b/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > > new file mode 100644
> > > index 0000000..a285695
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > > @@ -0,0 +1,15 @@
> > > +* Device tree bindings for Atmel GPBR (General Purpose Backup Registers)
> > > +
> > > +The GPBR are a set of battery-backed registers.
> > > +
> > > +Required properties:
> > > +- compatible: "atmel,at91sam9260-gpbr", "syscon"
> > > +- reg: contains offset/length value of the GPBR memory
> > > + region.
> > > +
> > > +Example:
> > > +
> > > +gpbr: gpbr@fffffd50 {
> >
> > Is something referencing this node via phandle? If not, please remove
> > the label.
>
> Yes, the rtt device is referencing it in its atmel,rtt-rtc-time-reg
> property (see patch 8 of this series).

How can I? You only sent me patch 9.

Patch looks good, I'm going to apply it.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/