Re: [PATCH v2 2/2] dt-bindings: add devicetree bindings for st-pwm regulator

From: Mark Brown
Date: Thu Sep 18 2014 - 18:23:38 EST


On Thu, Sep 18, 2014 at 02:27:59PM -0700, Doug Anderson wrote:
> On Thu, Sep 18, 2014 at 12:31 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:

> I would be tempted to say that you should add a few required properties:

> * regulator-boot-on
> * regulator-always-on
> * regulator-initial-microvolts

> From my understanding of how PWM-based regulators work there is no way
> to "disable" them. If you drive them low then they get their biggest
> voltage. If you drive them high then they get their smallest voltage.
> If you make them floating then it's equivalent to 50% duty cycle
> (right?)

No, if there is no disable operation then there is no point in
specifying any properties to do with enabling and disabling as they
won't do anything. This is only relevant if the operation is there.

Attachment: signature.asc
Description: Digital signature