Re: [PATCH] blk-mq: auto-start hw queue in requeue

From: Jens Axboe
Date: Fri Sep 19 2014 - 14:02:52 EST


On 09/19/2014 11:54 AM, Christoph Hellwig wrote:
> On Fri, Sep 19, 2014 at 11:52:59AM -0600, Jens Axboe wrote:
>> I agree. I think Ming wanted to avoid an unnecessary bitflip if
>> possible, but the fix is more convoluted than I would like.
>
> If the requeue from irq context ever ends up in the fast path we
> have much worse problems..

Oh yes certainly, my point was purely that I think this is why Mings fix
ended up being more involved than it need be.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/