RE: [PATCH] Export functions from pcie-designware

From: Mohit KUMAR DCG
Date: Wed Sep 24 2014 - 00:34:11 EST


Hello Bjorn,

> -----Original Message-----
> From: Bjorn Helgaas [mailto:bhelgaas@xxxxxxxxxx]
> Sent: Friday, September 19, 2014 10:46 AM
> To: Mohit KUMAR DCG
> Cc: Fabio Estevam; matwey@xxxxxxxxxx; Jingoo Han; linux-
> pci@xxxxxxxxxxxxxxx; linux-kernel; matwey.kornilov@xxxxxxxxx
> Subject: Re: [PATCH] Export functions from pcie-designware
>
> On Tue, Sep 16, 2014 at 10:11:22PM -0700, Bjorn Helgaas wrote:
> > On Tue, Sep 16, 2014 at 9:54 PM, Mohit KUMAR DCG
> <Mohit.KUMAR@xxxxxx> wrote:
> > > Hello Bjorn,
> > >
> > >> -----Original Message-----
> > >> From: Bjorn Helgaas [mailto:bhelgaas@xxxxxxxxxx]
> > >> Sent: Wednesday, September 17, 2014 5:09 AM
> > >> To: Fabio Estevam
> > >> Cc: matwey@xxxxxxxxxx; Mohit KUMAR DCG; Jingoo Han; linux-
> > >> pci@xxxxxxxxxxxxxxx; linux-kernel; matwey.kornilov@xxxxxxxxx
> > >> Subject: Re: [PATCH] Export functions from pcie-designware
> > >>
> > >> On Sat, Aug 30, 2014 at 10:07:30AM -0300, Fabio Estevam wrote:
> > >> > On Sat, Aug 30, 2014 at 9:24 AM, <matwey@xxxxxxxxxx> wrote:
> > >> > > From: "Matwey V. Kornilov" <matwey@xxxxxxxxxx>
> > >> > >
> > >> > > pcie-spear13xx when built as module requires the functions from
> > >> > > pcie-
> > >> designware.
> > >> > > Export them properly.
> > >>
> > >> I don't know how valuable pcie-spear13xx as a module is. No other
> > >> host drivers are supported as a module. Maybe we should just
> > >> change pcie- spear13xx from tristate to bool?
> > >>
> > > - Sachin's patch is already doing this:
> > > http://www.spinics.net/lists/linux-pci/msg33665.html
> > >
> > > You acknowledge it to apply for v3.17 but somehow it has been left out.
> >
> > Oops, sorry! I was pretty sure I remembered a patch like this, but
> > somehow I deleted the branch before it got fully merged. Anyway, I
> > re-did it. Thanks for the reminder.
>
> Actually, I *had* already merged it, and it's been in Linus' tree since
> 2014-09-03 15:45:48 (GMT) and appeared in v3.17-rc4:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers
> /pci/host/Kconfig?id=f16c15a0e0ea
>
- yes, its been merged. I think Fabio was working with v3.17-rc2 or earlier.

Fabio,
Pls let us know if you still have any concern after merging of this patch.

Thanks
Mohit

> Or am I still missing something?
>
> Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/