Re: [PATCH v14 net-next 10/11] bpf: verifier (add verifier core)

From: David Miller
Date: Fri Sep 26 2014 - 00:40:32 EST


From: Alexei Starovoitov <ast@xxxxxxxxxxxx>
Date: Sun, 21 Sep 2014 17:06:50 -0700

> +#define _(OP) ({ int ret = (OP); if (ret < 0) return ret; })

Please do not hide program control flow inside of a macro.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/