Re: [PATCH] x86, setup: add __flush_tlb() for Intel Quark X1000

From: Dave Hansen
Date: Fri Sep 26 2014 - 10:20:30 EST


On 09/26/2014 01:44 AM, Bryan O'Donoghue wrote:
>
> + /*
> + * Locate the page directory and flush the TLB.
> + *
> + * On Quark X1000 CPUs we still have the PGE bit incorrectly set
> + * due to a processor erratum, so __flush_tlb_all() is not yet
> + * doing what it says. Fortunately we have a cr3 flush here,
> + * which is what is needed in this processor to flush TLBs, so
> + * there's no need to add a Quark X1000 quirk here.
> + *
> + * early_init_intel will unset the X86_FEATURE_PGE flag later
> + * and __flush_tlb_all() will flush via cr3
> + */

That looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/