Re: [PATCH v3 00/17] Cross-architecture definitions of relaxed MMIO accessors

From: Arnd Bergmann
Date: Mon Sep 29 2014 - 05:50:59 EST


On Monday 29 September 2014 10:25:10 Will Deacon wrote:
> On Fri, Sep 26, 2014 at 10:36:13PM +0100, Arnd Bergmann wrote:
> > On Friday 26 September 2014 14:46:08 Russell King - ARM Linux wrote:
> > >
> > > Obviously, this does nothing for the:
> > >
> > > include/asm-generic/io.h:804:29: error: redefinition of 'virt_to_bus'
> > > include/asm-generic/io.h:809:21: error: redefinition of 'bus_to_virt'
> > >
> > > errors which are also reported in Olof's build system.
> > >
> > > Given how close we are to the merge window, I'd suggest this stuff gets
> > > reverted so that it can have a better period of testing, rather than
> > > stuffing it into -next at such a critical time.
> >
> > Right, I've fixed these all up locally, but then found new warnings on
> > allmodconfig builds that I haven't been able to track down yet.
> >
> > I've dropped everything from the asm-generic tree now, so we can get
> > a clean linux-next tree.
>
> Did you actually see any failures due to the relaxed I/O stuff, or was this
> all in the unrelated rework of the asm-generic/io.h file? If the latter, it
> would be a pity to postpone the former series.
>

I believe all the problems I've seen were because of Thierry's series,
I haven't tried separating the two again yet, which is something I'd
probably try today.

However, I saw a lot of different problems with the combined series
and I have a patch to fix them up here, will post that once I see no
new regressions.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/