Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2

[Heiko Stübner]

Am Dienstag, 30. September 2014, 09:43:47 schrieb Doug Anderson:
> Chris,
> 
> On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> > The min_uv in DCDC1 & DCDC2 should be 712.5mv
> > 
> > Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> > 
> > ---
> > 
> >  drivers/regulator/rk808-regulator.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/regulator/rk808-regulator.c
> > b/drivers/regulator/rk808-regulator.c index e305416..196a5c8 100644
> > --- a/drivers/regulator/rk808-regulator.c
> > +++ b/drivers/regulator/rk808-regulator.c
> > @@ -44,7 +44,7 @@ static const int rk808_buck_config_regs[] = {
> > 
> >  };
> >  
> >  static const struct regulator_linear_range rk808_buck_voltage_ranges[] =
> >  {
> > 
> > -       REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500),
> > +       REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500),
> > 
> >  };
> 
> I have no problem with this (and the current "dts" file I see don't go
> this low anyway), but it doesn't match the datasheet I have right now
> which says "0.700 V" is the min.

Then it would be problem.

The original statement above says, that a register value of "0" equals 700mV, 
so changing this in this way would mean everything runs 12.5mV above the 
target voltage.

And I can confirm, that the current datasheet lists 700mV as equallying 
register value 0.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/