Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

From: Greg Kroah-Hartman
Date: Tue Sep 30 2014 - 18:24:24 EST


On Tue, Sep 30, 2014 at 02:35:51PM -0700, Guenter Roeck wrote:
> On Tue, Sep 30, 2014 at 11:13:39PM +0200, Wolfram Sang wrote:
> >
> > > > Since this is a driver for a PCIe switch, I currently put it under /driver/pci/.
> > > > I'm very open to suggestions for moving this around (Does introducing
> > > > drivers/pci/switch/ seem any better?). Especially I can see that the
> > > > drivers/pci/Kconfig appears under "Bus Options" in the main menu which does not
> > > > look like the right place for this driver. I am looking for suggestions here.
> > >
> > > Definitely interesting work. I have no idea where to put it. It
> > > doesn't have anything to do with PCI core services or structures, so
> > > drivers/pci doesn't seem like the ideal place for it, but I don't have
> > > any better ideas. If it did end up under drivers/pci, I agree that a
> > > drivers/pci/switch or something similar would probably be better than
> > > having it directly in drivers/pci.
> > >
> > > Maybe Wolfram or other I2C folks will have an idea.
> >
> > Hmm, is this a common interface for those switches? Then a directory
> > like drivers/pci/switch could make sense. Otherwise I'd suggest
> > drivers/misc?
> >
> We had discussed drivers/misc internally, but it didn't seem to be the right
> location to me. After all, it is not a misc driver, but a driver to configure
> a PCIe switch. Not that I have a better idea, though.

drivers/misc is fine with me, I think we already have something like
this for I2C USB devices somewhere in the tree in that location.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/