Re: cehckpatch config symbol description false positive

From: Paul Bolle
Date: Thu Oct 02 2014 - 15:32:05 EST


Geert Uytterhoeven schreef op do 02-10-2014 om 21:08 [+0200]:
> When running checkpatch on
> http://marc.info/?l=linux-sh&m=141227657322649&w=2
> I get a false positive about the Kconfig symbol I just introduced, incl. a help
> text:
>
> WARNING: please write a paragraph that describes the config symbol fully
> #60: FILE: arch/arm/Kconfig.debug:702:
> + config DEBUG_SCIF

When you add one single line to your help (say, "Bla bla.") the warning
disappears. So you hit this test:
"please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);

because the paragraph was just three lines. It seems a length of one,
two, or three lines can be OK. It depends. Perhaps the test should just
be:
[...] && $length);


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/