Re: [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac address handling.

From: David Miller
Date: Fri Oct 03 2014 - 16:01:06 EST


From: Michael Welling <mwelling@xxxxxxxx>
Date: Wed, 1 Oct 2014 21:32:05 -0500

> The code currently checks the mac_addr variable that is clearly
> zero'd out during allocation.
>
> Further code is added to bring the mac_addr from the partial pdata.
>
> Signed-off-by: Michael Welling <mwelling@xxxxxxxx>

I don't see anyone specifying a MAC address in the partial pdata,
so better to just delete that field.

Even if people did, I am not so sure that the partial pdata should
unconditionally trump an OF provided MAC address.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/