Re: [tip:x86/asm] x86: Speed up ___preempt_schedule*() by using THUNK helpers

From: Linus Torvalds
Date: Fri Oct 03 2014 - 19:48:25 EST


On Fri, Oct 3, 2014 at 2:56 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>
> Is this thing missing a flags or cc clobber:
>
> # define __preempt_schedule() asm ("call ___preempt_schedule")

Yes, it should probably have a cc clobber. Although I think thet gcc
actually assumes all asms clobber flags on x86, so it shouldn't
matter.

> Is this all just to make the call sequence for preempt_schedule shorter?

Not so much the call sequence, but the code around the call - not
havign to spill live registers etc. But yes.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/