RE: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags

From: Chen, Hanxiao
Date: Mon Oct 06 2014 - 05:21:50 EST




> -----Original Message-----
> From: containers-bounces@xxxxxxxxxxxxxxxxxxxxxxxxxx
> [mailto:containers-bounces@xxxxxxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Richard Guy
> Briggs
> Sent: Monday, October 06, 2014 1:09 PM
> To: linux-audit@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: eparis@xxxxxxxxxx; pmoore@xxxxxxxxxx; aviro@xxxxxxxxxx; sgrubb@xxxxxxxxxx;
> ebiederm@xxxxxxxxxxxx
> Subject: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags
>
> ---
> include/uapi/linux/sched.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index 34f9d73..5aceba2 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -28,6 +28,12 @@
> #define CLONE_NEWUSER 0x10000000 /* New user namespace */
> #define CLONE_NEWPID 0x20000000 /* New pid namespace */
> #define CLONE_NEWNET 0x40000000 /* New network namespace */
> +#define CLONE_NEW_MASK ( CLONE_NEWNS \
> + | CLONE_NEWUTS \
> + | CLONE_NEWIPC \
> + | CLONE_NEWUSER \
> + | CLONE_NEWPID \
> + | CLONE_NEWNET) /* mask of all namespace type flags */
> #define CLONE_IO 0x80000000 /* Clone io context */
>

The name 'CLONE_NEW_MASK' may confuse readers.
How about something like CLONE_NEW_MASK_ALL?

Thanks,
- Chen