Re: [PATCH v2 12/15] virtio_blk: enable VQs early

From: Cornelia Huck
Date: Mon Oct 06 2014 - 11:42:49 EST


On Mon, 6 Oct 2014 18:11:22 +0300
"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:

> virtio spec requires drivers to set DRIVER_OK before using VQs.
> This is set automatically after probe returns, virtio block violated this
> rule by calling add_disk, which causes the VQ to be used directly within
> probe.
>
> To fix, call virtio_enable_vqs_early before using VQs.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
> drivers/block/virtio_blk.c | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/