Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy

From: Guenter Roeck
Date: Sat Oct 11 2014 - 22:25:44 EST


On Sat, Oct 11, 2014 at 07:11:22PM -0700, Guenter Roeck wrote:
> On Sat, Oct 11, 2014 at 05:27:41PM -0700, Mark D Rustad wrote:
> > On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Changed from using strncpy to strlcpy to simplify the code
> >
> > Actually you changed from using strncat to strlcat.
> >
> ... and changed the length parameter along the way, making the length check
> overall quite worthless and introducing a _real_ problem.
>
Me talking nonsense; ignore this noise.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/