Re: [PATCH] usb: dwc3: be more verbose on ERRATIC_ERROR interrupt

[Felipe Balbi]

Hi,

On Tue, Oct 14, 2014 at 01:15:05PM -0700, David Cohen wrote:
> ERRATIC_ERROR interrupt is an event that needs more attention from
> developers than currently implemented, since this indicates a serious
> stability issue. The only way to get warned about it is by selecting the
> maximum driver's verbosity.
> 
> This patch increases a bit the error's verbosity.
> 
> Signed-off-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>
> ---
>  drivers/usb/dwc3/gadget.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 3818b26bfc05..132e761d62e4 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -2484,7 +2484,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc,
>  		dev_vdbg(dwc->dev, "Start of Periodic Frame\n");
>  		break;
>  	case DWC3_DEVICE_EVENT_ERRATIC_ERROR:
> -		dev_vdbg(dwc->dev, "Erratic Error\n");
> +		WARN_ON_ONCE(1);
> +		dev_dbg(dwc->dev, "Erratic Error\n");

how about:
		WARN_ONCE(true, "Erratic Error\n");

instead ?

>  		break;
>  	case DWC3_DEVICE_EVENT_CMD_CMPL:
>  		dev_vdbg(dwc->dev, "Command Complete\n");
> -- 
> 2.1.0
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature