Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

From: Greg KH
Date: Thu Oct 16 2014 - 04:14:19 EST


On Wed, Oct 15, 2014 at 03:59:21PM -0700, Jeff Kirsher wrote:
> On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote:
> > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> >
> > The Beceem WIMAX was generating compile warnings on 64bit machines,
> > which were:
> >
> > drivers/staging/bcm/CmHost.c: In function âStoreCmControlResponseMessageâ:
> > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > (struct bcm_connect_mgr_params *) ntohl(
> > ^
> > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > (struct bcm_connect_mgr_params *) ntohl(
> > ^
> > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > (struct bcm_connect_mgr_params *) ntohl(
> >
> > This resolves the issue by preventing the driver to compile if CONFIG_64BIT
> > is enabled, since the driver is known to be broken for 64 bit arch's.
> >
> > CC: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > CC: Joe Perches <joe@xxxxxxxxxxx>
> > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
>
> Greg- I have also submitted a patch to remove this driver entirely. So
> if you choose to apply the patch to remove the driver, then you can
> disregard this patch.

Thanks, I'll take that removal patch now, I'm glad to get rid of that
mess.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/