Re: unaligned accesses in SLAB etc.

From: David Miller
Date: Thu Oct 16 2014 - 16:20:24 EST


From: Meelis Roos <mroos@xxxxxxxx>
Date: Thu, 16 Oct 2014 23:16:44 +0300 (EEST)

>> > scripts/Makefile.build:352: recipe for target 'sound/modules.order' failed
>> > make[1]: *** [sound/modules.order] Bus error
>> > make[1]: *** Deleting file 'sound/modules.order'
>> > Makefile:929: recipe for target 'sound' failed
>>
>> I just reproduced this on my Sun Blade 2500, so it can trigger on UltraSPARC-IIIi
>> systems too.
>
> My bisection led to the folloowing commit but it seems irrelevant (I
> have no sun4v on these machines):
>
> 4ccb9272892c33ef1c19a783cfa87103b30c2784 is the first bad commit
> commit 4ccb9272892c33ef1c19a783cfa87103b30c2784
> Author: bob picco <bpicco@xxxxxxxxxx>
> Date: Tue Sep 16 09:26:47 2014 -0400
>
> sparc64: sun4v TLB error power off events
>
>
> However, the following chunk sound slightly suspicious:
>
> + if (fault_code & FAULT_CODE_BAD_RA)
> + goto do_sigbus;
> +
>
> because SIGNUS is what I got. For some machines, it killed chekroot
> during startup, for some shells under some circumstances, for some sshd.

Good catch!

So I'm going to audit all the code paths to make sure we don't put garbage
into the fault_code value.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/