Re: [PATCH 1/6] scsi_dh: get module reference outside of device handler

From: Christoph Hellwig
Date: Mon Oct 20 2014 - 02:54:05 EST


On Mon, Oct 20, 2014 at 08:01:20AM +0200, Hannes Reinecke wrote:
> Is it guaranteed that you cannot call ->attach() for devices which
> already have a device_handler attached?
> You've skipped the case
>
> scsi_dh != sdev->scsi_dh_data->scsi_dh

No. Just instead of an if / else it's an if with an early return in the
new code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/