Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

[Mark Brown]

On Thu, Oct 23, 2014 at 12:14:43PM +0900, Gyungoh Yoo wrote:

> So, what do you think about DT like below?

> sky81452@2c {
> 	compatible = "skyworks,sky81452";
> 	reg = <0x2c>;
> 
> 	backlight {
> 		compatible = "skyworks,sky81452-backlight";
> 		name = "pwm-backlight";
> 		enable = <0x3F>;
> 		ignore-pwm;
> 	};
> 
> 	regulator {
> 		compatible = "skyworks,sky81452-regulator";

Yes, this is good but I still feel that the above compatible is
redundant and shouildn't be there.

> 		lout@0 {
> 			regulator-name = "LOUT";
> 			regulator-min-microvolt = <4500000>;
> 			regulator-max-microvolt = <8000000>;
> 		};
> 	};
> };

Attachment: signature.asc
Description: Digital signature