Re: [PATCH 06/14] net: dsa: Add support for hardware monitoring

[Guenter Roeck]

On 10/23/2014 10:03 PM, David Miller wrote:
> From: Guenter Roeck <linux@xxxxxxxxxxxx>
> Date: Wed, 22 Oct 2014 22:06:41 -0700
>
> > On 10/22/2014 09:37 PM, Florian Fainelli wrote:
> > > 2014-10-22 21:03 GMT-07:00 Guenter Roeck <linux@xxxxxxxxxxxx>:
> > > > Some Marvell switches provide chip temperature data.
> > > > Add support for reporting it to the dsa infrastructure.
> > > >
> > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > > ---
> > > [snip]
> > >
> > > > +/* hwmon support
> > > > ************************************************************/
> > > > +
> > > > +#if defined(CONFIG_HWMON) || (defined(MODULE) &&
> > > > defined(CONFIG_HWMON_MODULE))
> > >
> > > IS_ENABLED(CONFIG_HWMON)?
> >
> > Hi Florian,
> >
> > unfortunately, that won't work; I had it initially and got a nice
> > error message
> > from Fengguang's build test bot.
>
> Then the Kconfig dependencies are broken.
>
> Fix Kconfig to only allow legal combinations.

I see two options for that:

- Add
	select HWMON
  to the NET_DSA Kconfig entry.
  Example is Broadcom TIGON3 driver.

- Add a DSA_HWMON Kconfig entry to define the dependencies and
  to let the user select if the functionality should be enabled.
  Example is Intel IGB driver.

Any preference from your side ? If no, I'll go with the latter.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/