Re: [PATCH 06/14] net: dsa: Add support for hardware monitoring

From: David Miller
Date: Fri Oct 24 2014 - 02:10:21 EST


From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Thu, 23 Oct 2014 22:40:59 -0700

> I see two options for that:
>
> - Add
> select HWMON
> to the NET_DSA Kconfig entry.
> Example is Broadcom TIGON3 driver.
>
> - Add a DSA_HWMON Kconfig entry to define the dependencies and
> to let the user select if the functionality should be enabled.
> Example is Intel IGB driver.
>
> Any preference from your side ? If no, I'll go with the latter.

Probably the latter is better, select can get you into trouble.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/