Re: [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2

From: Milosz Tanski
Date: Fri Oct 24 2014 - 13:08:47 EST


On Fri, Oct 24, 2014 at 5:36 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> diff --git a/mm/filemap.c b/mm/filemap.c
>> index cb7f530..45964c8 100644
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -1735,7 +1735,7 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
>> }
>> }
>>
>> - retval = do_generic_file_read(file, ppos, iter, retval);
>> + retval = do_generic_file_read(file, ppos, iter, retval, iocb->ki_rwflags);
>
> I think this belongs into the last patch, together with the last hunk
> from the first patch.
>
> Otherwise looks good to me:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I pushed the change from the previous patch to the prototype of
do_generic_file_read into this patch.

--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/