Re: [PATCH 3/4] pinctrl: ralink: add binding documentation

From: Linus Walleij
Date: Mon Oct 27 2014 - 12:22:24 EST


On Thu, Oct 9, 2014 at 4:55 AM, John Crispin <blogic@xxxxxxxxxxx> wrote:

> Signed-off-by: John Crispin <blogic@xxxxxxxxxxx>

This does not seem complete since it lacks things like the very
controversial gpio-base thing.

> +++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.txt
> @@ -0,0 +1,74 @@
> +Ralink rt2880 pinmux controller
> +
> +Required properties:
> +- compatible: "lantiq,rt2880-pinmux"
> +- reg: Should contain the physical address and length of the gpio/pinmux
> + register range
> +
> +The rt2880 pinmux can only set the muxing of pin groups. muxing indiviual pins
> +is not supported. There is no pinconf support.
> +
> +Definition of mux function groups:
> +
> +Required subnode-properties:
> +- ralink,group : An array of strings. Each string contains the name of a group.
> + Valid values for these names are listed below.
> +- ralink,function: A string containing the name of the function to mux to the
> + group. Valid values for function names are listed below.

Just use "function" and "group" from the generic bindings.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/