Re: I2C OF IRQ parsing issue due to probe ordering

From: Thierry Reding
Date: Thu Oct 30 2014 - 09:44:23 EST


On Thu, Oct 30, 2014 at 03:22:49PM +0200, Laurent Pinchart wrote:
> Hi Wolfram,
>
> On Thursday 30 October 2014 14:21:36 Wolfram Sang wrote:
> > > > See:
> > > > 9ec36cafe43b of/irq: do irq resolution in platform_get_irq
> > > >
> > > > I suspect a similar thing could be done for I2C.
> > >
> > > That could work. We would need to introduce a new i2c_get_irq() function
> > > though. Wolfram, would you be fine with that ?
> >
> > I'd think it will look pretty similar to platform_get_irq, no? That is
> > fine with me.
>
> It would, but as Thierry pointed out it should be possible to hide the details
> in the I2C core. I'll submit a patch shortly.

i2c_device_probe() seems exactly the right place to do this. It's in
fact the equivalent of what I had proposed in my original patch series
where this was done in platform_drv_probe().

Thierry

Attachment: pgpa4w5pYk7f0.pgp
Description: PGP signature