Re: PATCH: Add IFF_ALLMULTI support to cpsw (and fix IFF_PROMISC support too)

From: David Miller
Date: Thu Oct 30 2014 - 16:13:00 EST


From: "Lennart Sorensen" <lsorense@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 29 Oct 2014 15:06:12 -0400

> The cpsw driver did not support the IFF_ALLMULTI flag which makes dynamic
> multicast routing rather hard to handle. Related to this, when enabling
> IFF_PROMISC in non dual_emac mode, all registered vlans are flushed,
> and only broadcast and unicast are allowed which isn't what you would
> want from IFF_PROMISC.
>
> A new cpsw_ale_set_allmulti function now scans through the ALE entry
> table and adds or removes the host port from the unregistered multicast
> port mask depending on the state of IFF_ALLMULTI. In promisc mode,
> it is also called to enable reception of all multicast traffic.
>
> With this change I am now able to run dynamic multicast routing and also
> use tcpdump and actually see multicast traffic.
>
> Signed-off-by: Len Sorensen <lsorense@xxxxxxxxxxxxxxxxxxx>

Please fix your Subject line and resubmit this patch.

Subject lines end up as the commit message header text, and
therefore must be of the form:

subsystem: Description.

In this case "cpsw: " is probably an appropriate subsystem
prefix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/