Re: [PATCH v3 09/47] mfd: palmas: Register with kernel power-off handler

From: Guenter Roeck
Date: Mon Nov 03 2014 - 13:58:18 EST


On Mon, Nov 03, 2014 at 12:43:12PM -0600, Felipe Balbi wrote:
> On Mon, Nov 03, 2014 at 10:36:53AM -0800, Guenter Roeck wrote:
> > On Mon, Nov 03, 2014 at 11:59:54AM -0600, Felipe Balbi wrote:
> > > On Mon, Nov 03, 2014 at 05:56:45PM +0000, Lee Jones wrote:
> > > > On Mon, 27 Oct 2014, Guenter Roeck wrote:
> > > >
> > > > > Register with kernel power-off handler instead of setting pm_power_off
> > > > > directly. Register with low priority to reflect that the original code
> > > > > only sets pm_power_off if it was not already set.
> > > > >
> > > > > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> > > > > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > > > ---
> > > > > v3:
> > > > > - Replace poweroff in all newly introduced variables and in text
> > > > > with power_off or power-off as appropriate
> > > > > - Replace POWEROFF_PRIORITY_xxx with POWER_OFF_PRIORITY_xxx
> > > > > v2:
> > > > > - Use define to specify poweroff handler priority
> > > > > - Use devm_register_power_off_handler
> > > > > - Use dev_warn instead of dev_err
> > > > >
> > > > > drivers/mfd/palmas.c | 31 +++++++++++++++++--------------
> > > > > include/linux/mfd/palmas.h | 3 +++
> > > > > 2 files changed, 20 insertions(+), 14 deletions(-)
> > > >
> > > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > >
> > > missed lakml and linux-omap.
> > >
> > Felipe,
> >
> > unfortunately, get_maintainer.pl doesn't give a hint that this and the
> > other affected patches should be sent to linux-omap. How am I supposed
> > to know ?
>
> yeah, just looked and nobody bothered to patch MAINTAINERS when those
> files were added. I just sent a patch adding them under OMAP SUPPORT.
>
I'll add the omap list as Cc: to the affected patches directly for now.

> > Note that linux-kernel@xxxxxxxxxxxxxxx was copied on the entire series,
> > if that is what you mean with lakml. linux-pm@xxxxxxxxxxxxxxx was also
> > copied on all patches. Additional mailing lists were only copied for
> > affected architectures to avoid for the patches to be tagged as spam.
> >
> > If there is a list named lakml, I must have missed it, and I seem to be
> > unable to find a reference to it. If that is the case, my apologies,
> > and please provide a link to it.
>
> here it is:
>
> Linux ARM Kernel Mailing List <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
>
Same problem here, though. If there are any ARM specific patches where the arm
mailing list was not copied, that was because the dependency is not listed in
the MAINTAINERS file. As mentioned before, copying the entire series to all
lists touched by one of the patches in the series just doesn't work (and may
be considered severe noise by some subscribers of those lists).

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/