Re: [PATCH v3 08/14] mfd: max77686/802: Remove support for board files

From: Lee Jones
Date: Tue Nov 04 2014 - 03:08:03 EST


On Tue, 04 Nov 2014, Krzysztof Kozlowski wrote:

> On pon, 2014-11-03 at 17:01 +0000, Lee Jones wrote:
> > On Thu, 30 Oct 2014, Krzysztof Kozlowski wrote:
> >
> > > The driver is used only on Exynos based boards with DTS support.
> > > Convert the driver to DTS-only version. This simplifies a little the
> > > code:
> > > 1. No dead (unused) entries in platform_data structure.
> > > 2. More code removed.
> > > 3. Regulator driver does not depend on allocated memory
> > > from MFD driver.
> > > 4. It makes also easier extending the regulator driver.
> > >
> > > Add to the max77686 MFD driver dependency on CONFIG_OF because without
> > > DTS the regulator drivers won't bind.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > > Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > drivers/mfd/max77686.c | 23 -----------------------
> > > include/linux/mfd/max77686-private.h | 1 -
> > > include/linux/mfd/max77686.h | 28 ----------------------------
> > > 4 files changed, 1 insertion(+), 52 deletions(-)
> >
> > Applied, thanks.
>
>
> Noooo, don't apply it. It depends on previous patches removing the board
> file support from regulators.
>
> If the patch looks OK, please only ack it. I would like to push
> everything through regulator tree.

Very well, patch dropped.

As long as Mark puts it on a succinct tagged branch it can go in
through his tree:

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

Mark,
Please send me the tag to pull from once applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/