Re: [PATCH 6/8] perf record: Do not save pathname in ./debug/.build-id directory for vmlinux

From: Namhyung Kim
Date: Tue Nov 04 2014 - 21:54:37 EST


Hi Arnaldo,

On Tue, 4 Nov 2014 10:29:04 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 04, 2014 at 10:14:32AM +0900, Namhyung Kim escreveu:
>> When perf record finishes a session recording, it then pre-process
>> samples in order to write build-id info from actually used DSOs.
>> During this process it'll call map__load() for kernel map, and it ends
>> up calling dso__load_vmlinux_path() which replaces dso->long_name.
>
> Can't we achieve the same end result without introducing yet another
> symbol_conf entry?
>
> I think there are way too many there, we need to remove, not add :-\

Agreed.

I also wanted to do it without a new entry, but failed to find a good
way of it as it's a common code called both from record and report path
and lives in a deep inside of sample processing.

>
> I'll add this since it improve the end result, but if you don't beat me
> to it I'll try to remove this symbol_conf entry while keeping the end
> result you achieved with it.

It'd be really appreciated!

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/