Re: [RESEND PATCH 3.18-rc3] kdb: Avoid printing KERN_ levels to consoles

From: Joe Perches
Date: Thu Nov 06 2014 - 11:13:34 EST


On Thu, 2014-11-06 at 15:27 +0000, Daniel Thompson wrote:
> Currently when kdb traps printk messages then the raw log level prefix
> (consisting of '\001' followed by a numeral) does not get stripped off
> before the message is issued to the various I/O handlers supported by
> kdb. This causes annoying visual noise as well as causing problems
> grepping for ^. It is also a change of behaviour compared to normal usage
> of printk() usage. For example <SysRq>-h ends up with different to that of
> kdb's "sr h".
>
> This patch addresses the problem by stripping log levels from messages
> before they are issued to the I/O handlers.

Perhaps instead of stripping the logging level,
maybe a KERN_SOH_ASCII 'char' sequence should be
emitted as '<' 'char' '>' (see: printk:print_prefix)

Maybe this should be added to stable from v3.6
when KERN_SOH_ASCII was first added.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/