Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

From: Guenter Roeck
Date: Sun Nov 09 2014 - 18:55:14 EST


On 11/09/2014 01:41 PM, Marc Dietrich wrote:
Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck:
Register with kernel power-off handler instead of setting pm_power_off
directly. Register with default priority since we don't know any better.

Cc: Julian Andres Klode <jak@xxxxxxxxxxxxx>
Cc: Marc Dietrich <marvin24@xxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx

ok, this version (V5) actually switches the device off in contrast to the
first implementation. Somehow I have to find out why it works at all without
irqs.

Acked-by: Marc Dietrich <mavin24@xxxxxx>


Hi Marc,

The most recent version does not turn off interrupts as long as the
infrastructure (architecture code, ie machine_power_off) doesn't
turn it off.

Thanks a lot for (re-)testing.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/