Re: [PATCH v2 1/1] ftruncate, truncate: create fanotify events

[Christoph Hellwig]

On Mon, Nov 10, 2014 at 09:30:29PM +0100, Jan Kara wrote:
>   So what I somewhat dislike about this patch is that notify_change() is
> sometimes called with dentry and sometimes with path. That way it's not
> completely clear when fanotify events will be generated and when not.
> Sadly it isn't easy to provide struct path in all the places where we are
> calling notify_change() so I'm not sure what would a better solution look
> like either :(

I suspect the right thing to do is to split out the truncate path
from notify_change, as it's fairly different anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/