Re: [PATCH 2/4] Documentation: DT: Add documentation for ti,opa362 bindings

From: Tomi Valkeinen
Date: Wed Nov 12 2014 - 09:06:48 EST


On 03/11/14 23:59, Marek Belisko wrote:
> Signed-off-by: Marek Belisko <marek@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/video/ti,opa362.txt | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/ti,opa362.txt
>
> diff --git a/Documentation/devicetree/bindings/video/ti,opa362.txt b/Documentation/devicetree/bindings/video/ti,opa362.txt
> new file mode 100644
> index 0000000..d7ed11a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/ti,opa362.txt
> @@ -0,0 +1,38 @@
> +OPA362 analog video amplifier
> +
> +Required properties:
> +- compatible: "ti,opa362"
> +- gpio: enable/disable output gpio
> +
> +Required node:
> +- Video port 0 for opa362 input
> +- Video port 1 for opa362 output
> +
> +Example:
> +
> +tv_amp: opa362 {
> + compatible = "ti,opa362";
> + gpios = <&gpio1 23 0>; /* GPIO to enable video out amplifier */
> +
> + label = "opa362";

opa shouldn't have label property. label is meant for the
end-of-the-chain component, like the connector.

> + ports {

Hmm, I think there is extra space before 'ports', maybe below also.

Tomi


Attachment: signature.asc
Description: OpenPGP digital signature