[PATCH 1/1] fcoe: use continue instead of goto+label

From: Jiri Slaby
Date: Wed Nov 12 2014 - 10:01:35 EST


There is a label pointing to the start of a while loop and a goto
nested only in the loop. The goto jumps to the label in some cases.
Replace the goto and the label by simple continue.

Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
Cc: Robert Love <robert.w.love@xxxxxxxxx>
Cc: fcoe-devel@xxxxxxxxxxxxx
---
drivers/scsi/fcoe/fcoe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 4a8ac7d8c76b..f9eef51c9823 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1874,7 +1874,6 @@ static int fcoe_percpu_receive_thread(void *arg)

set_user_nice(current, MIN_NICE);

-retry:
while (!kthread_should_stop()) {

spin_lock_bh(&p->fcoe_rx_list.lock);
@@ -1884,7 +1883,7 @@ retry:
set_current_state(TASK_INTERRUPTIBLE);
spin_unlock_bh(&p->fcoe_rx_list.lock);
schedule();
- goto retry;
+ continue;
}

spin_unlock_bh(&p->fcoe_rx_list.lock);
--
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/