Re: [PATCH 2/2] kernel: add support for live patching

From: Miroslav Benes
Date: Thu Nov 13 2014 - 05:16:14 EST



Hi,

thank you for the first version of the united live patching core.

The patch below implements some of our review objections. Changes are
described in the commit log. It simplifies the hierarchy of data
structures, removes data duplication (lp_ and lpc_ structures) and
simplifies sysfs directory.

I did not try to repair other stuff (races, function names, function
prefix, api symmetry etc.). It should serve as a demonstration of our
point of view.

There are some problems with this. try_module_get and module_put may be
called several times for each kernel module where some function is
patched in. This should be fixed with module going notifier as suggested
by Petr.

The modified core was tested with modified testing live patch originally
from Seth's github. It worked as expected.

Please take a look at these changes, so we can discuss them in more
detail.

Best regards,
--
Miroslav Benes
SUSE Labs


----