Re: [PATCHv2 net 2/2] fm10k: Implement ndo_gso_check()

From: Joe Stringer
Date: Thu Nov 13 2014 - 19:29:24 EST


On Thursday, November 13, 2014 16:12:39 Jeff Kirsher wrote:
> On Thu, 2014-11-13 at 15:52 -0800, Joe Stringer wrote:
> > On Thu, Nov 13, 2014 at 03:41:56PM -0800, Jeff Kirsher wrote:
> > > On Thu, 2014-11-13 at 15:36 -0800, Joe Stringer wrote:
> > > > ndo_gso_check() was recently introduced to allow NICs to report
> >
> > the
> >
> > > > offloading support that they have on a per-skb basis. Add an
> > > > implementation for this driver which checks for something that
> >
> > looks
> >
> > > > like VXLAN.
> > > >
> > > > Signed-off-by: Joe Stringer <joestringer@xxxxxxxxxx>
> > > > ---
> > > > v2: Reuse fm10k_tx_encap_offload().
> > > > ---
> > > >
> > > > drivers/net/ethernet/intel/fm10k/fm10k.h | 1 +
> > > > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-
> > > > drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 8 ++++++++
> > > > 3 files changed, 10 insertions(+), 1 deletion(-)
> > >
> > > Same with this one as well, thanks Joe.
> >
> > Thanks Jeff.
> >
> > Could you remind me, is the equivalent i40e patch on your queue or
> > were
> > we still waiting on further feedback from Shannon/Jesse?
>
> Actually, looks like I dropped the patch due to community feedback and
> was expecting a v2. Was I incorrect in doing so?

That's fine. There were some unresolved questions for what that version should
look like, but I can repost to start the discussion again.

Cheers,
Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/