Re: [PATCH] brcmfmac: fix error handling of irq_of_parse_and_map

From: Arend van Spriel
Date: Sun Nov 16 2014 - 08:02:37 EST

On 11/14/14 23:12, Dmitry Torokhov wrote:
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.

Whoops, that is bad. Thanks for catching this. It probably needs to go to stable as well for 3.17 kernel.

+Cc: stable@xxxxxxxxxxxxxxx # v3.17
+Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>
Signed-off-by: Dmitry Torokhov<dtor@xxxxxxxxxxxx>

Not tested, found by casual code inspection.

drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b/drivers/net/wireless/brcm80211/brcmfmac/of.c
index eb3fce82..c824570 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/of.c
@@ -40,8 +40,8 @@ void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)

irq = irq_of_parse_and_map(np, 0);
- if (irq< 0) {
- brcmf_err("interrupt could not be mapped: err=%d\n", irq);
+ if (!irq) {
+ brcmf_err("interrupt could not be mapped\n");
devm_kfree(dev, sdiodev->pdata);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at