Re: [PATCH] ASoC: samsung-i2s: Add 192kHz config option

From: Mark Brown
Date: Mon Nov 17 2014 - 09:58:17 EST

On Mon, Nov 17, 2014 at 10:57:54AM +0000, Richard Fitzgerald wrote:
> Adds QUIRK_SUPPORTS_192KHZ to allow 192kHz rate
> to be selected for hardware that supports it.

> +- samsung,supports-192khz: specify this (without a value) if you want to allow
> + 192000 sample rate over the I2S link.

Two things here. One is that the first half is a funny way of saying
"boolean property" (the other standard idiom is "present if..."). The
other is that "if you want to allow" suggests that this is a bit of
runtime configuration (which shouldn't be in device tree at all). If
there's a quirk here it should be a fixed property of the hardware, if
this is a system integration choice then it should at most be specified
in the machine driver and the I2S controller should just advertise
whatever it's physically capable of.

Attachment: signature.asc
Description: Digital signature