Re: [PATCHv4 2/6] phy: improved lookup method
From: Heikki Krogerus
Date: Mon Nov 17 2014 - 10:40:41 EST
On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote:
> How about adding the change in attached patch  on top of this patch.
> Just introduced the phy pointer in "phy_lookup" structure, and
> modified phy_find() accordingly.
I would be fine if we used the phy pointer to match, but if we have
the pointer to the phy in the lookup, then I would say we need to
remove the phy_name member.
Otherwise we would have to support two ways of finding the lookups
(one for the "static" lookups where we match to the phy_name and other
where we match to the pointer). That means we will also not be able to
create "static" lookups, but those would be only needed if we wanted to
create them in board files. I don't think there will ever be need to
create the lookups in board files, so I'm more then happy to remove
the static way of creating the lookups.
Kishon, if you are OK with this change, I'll prepare new version of
this set and use the idea. Vivek, you'll get the credit for it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/