Re: [PATCH 00/10] Save MSI chip in pci_sys_data
From: Thomas Gleixner
Date: Mon Nov 17 2014 - 16:31:26 EST
On Mon, 17 Nov 2014, Bjorn Helgaas wrote:
> Super. Thank you very much for taking care of this; it's a big weight
> off my mind.
> You can add my Acked-by to these patches if you want it. I would
> suggest a minor comment expansion here, just because the code *looks
> like* it's setting up something to match a hardware device:
> > +/**
> > + * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
> > + * @dev: Pointer to the PCI device
> > + * @desc: Pointer to the msi descriptor
> > + *
> > + * The ID number is only used within the irqdomain.
> Maybe include something like:
> This "irq_hw_number_t" is an opaque identifier used only by the
> irqdomain code.
> It does not correspond to any hardware implementation or register encoding.
Yes, that's really a way better description of it.
Thanks for having a look!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/