Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper

From: Jonathan Corbet
Date: Tue Nov 18 2014 - 08:03:24 EST

On Tue, 18 Nov 2014 11:23:35 +0000
"Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> wrote:

> drivers/media/platform/marvell-ccic/mcam-core.c | 29 +++++--------------------
> 1 file changed, 5 insertions(+), 24 deletions(-)

So I'm not convinced that this patch improves things; it moves a tiny bit
of code into another file where anybody reading the driver will have to
go look to see what's going on. But I guess it doesn't really make
things worse either; I won't try to stand in its way. It would be nice
to see a real changelog on the patch, though.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at