Re: [PATCH 2/2] tracing: Use trace_seq_used() and seq_buf_used() instead of len

From: Steven Rostedt
Date: Wed Nov 19 2014 - 10:01:34 EST


On Wed, 19 Nov 2014 15:40:05 +0100
Petr Mladek <pmladek@xxxxxxx> wrote:

> > s->seq.len will never be more than s->seq.size after the test against
> > TRACE_MAX_PRINT. So I see no harm here.
>
> Ah, I see. Well, I would feel more comfortable if it uses
> trace_seq_used() or if there is some explanation in a comment.
> But you are right, it is safe as it is. Feel free to leave it.

Yeah, a comment would be nice. I may add it late.

>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxx>

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/